This repository was archived by the owner on Oct 25, 2023. It is now read-only.
Skip script tags that don't include JS code#21
Open
szimek wants to merge 1 commit intomapbox:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've been playing a bit with this plugin as I was trying to set up ESLint to lint JS code in Liquid templates. One of the issues I had was that I've got a bunch of script tags with JSON LD data and, as it's just JSON and not JS, ESLint reports parser errors.
This PR makes sure that only code from script tags without any
typeattribute or withtypeattribute equal totext/javascriptis processed and passed to ESLint.Instead of asserting number of reported messages it could assert that there are no messages that include
'Parsing error', but this way seems good enough.